Cause signing out is a function of the session being revoked

but yea.. i get your point. It's more intuitive if it's in the

ThirdPartyEmailPassword

. Perhaps you could create an issue about this and we can deal with it soonish..

But until then, i'm afraid that you will have to have the

SUCCESS

check in the

ThirdPartyEmailPassword.init

and the

SIGN_OUT

check in the

Session.init

I see, how do "SUCCESS" and "SESSION_CREATED" context action differ then?

With SUCCESS, you can know if it's a sign up or sign in. However with SESSION_CREATED, you can't know that.

Okay, so I have the option of moving all the post sign up/in and sign out events to session.init

It seems better as I am not making use of this difference.

yea.. then move it all in session.init.. no problem!

Sure, I will make an issue regarding it.

Thanks again.

Also, since you have upgraded to 0.15, it has a breaking change for how components override works. The function signature has changed slighty.

The components override API has changed from

(DefaultComponent) => (props) => React.Element

to

({ DefaultComponent, …props }) => React.Element

.

Okay, got it.

It had to be done cause the older way had a bug that would cause your custom component’s state to be forgotten on rerender

There's another issue, I think because of the page refresh just after sign up, the GET request that is supposed to run on SIGN_OUT gets aborted, more specifically "NS_BINDING_ABORTED"

Ahhhhh I see

Yeaaa. So that’s tricky

Oh, what do you mean by forgotten? Why did that happen?

Yep 😅

By forgotten, I meant that the component would be remounted. So the state would be reset. It happened cause earlier, we would render the component returned from the function as opposed to treating the function itself as a component (which happens now)

So the way I would solve that is that whenever you call the sign out function, after that, you should send the axios call and then do the redirection. As opposed to listening for the event

Or, you do the redirection using react router Dom which doesn’t lead to a page reload. So your axios would not get cancelled

Hmm, so overriding the function like you mentioned before.

I understand, thanks for the explanation.

Yea.. thought could work too.

No worries, I will try that. It's good finding issues.

Hey. I am getting 401s in Safari. I seem to be running afoul of cross-site tracking.

I would need more context to help debug: - What's your website domain - Are you using iframes? - What's your api domain? - Your frontend and backend init config