Hi @rp, my work colleague wrote to you today about creating a PR for the config I made all the necessary changes, passed all the tests. Are there any specific instructions which I need to follow to create a PR in supertokens-node correctly? Thank you

Hey @IaS1506 you can just create a PR to our master branch. Ill point out if anything missing / wrong.

Ok

ah right. We will test it ourselves as well.

with this

right. That's OK.. we will run the tests on our end

ok(1 thousand+ tests, you are cool)

what we have over 1k tests? i don't think so

why not

hmm! cool

so, should i pr all this generated from build-pretty files or only ts js and d.ts files?

the build files as well.

thanks. Will see.

Good afternoon, I have updated PR

ok so the code changes look fine now

And how to run one concrete test

you can do

it.only(...)

at the very first line, there is

it(..

, change that to

it.only(...

to run just this test

I get this bc in one terminal i started testing env

whats the command you are running for tests?

it run all tests

as i said, change the code to do

it.only(..

aa? okey

then maybe there is some bug

Changed: new NormalisedURLPath("/") is setting to ' '

yea, that's expected

{ STExpress.init({ supertokens: { connectionURI: "http://localhost:8080", }, appInfo: { apiDomain: "api.supertokens.io", appName: "SuperTokens", websiteDomain: "supertokens.io", }, recipeList: [Session.init({ getTokenTransferMethod: () => "cookie" })], }); console.log( "Path: ", SessionRecipe.getInstanceOrThrowError().config.accessTokenPath.getAsStringDangerous() ); assert(SessionRecipe.getInstanceOrThrowError().config.accessTokenPath.getAsStringDangerous() === "/"); resetAll(); }

yea, cause

SessionRecipe.getInstanceOrThrowError().config.accessTokenPath.getAsStringDangerous()

should be equal to

""

Yeah, I have two tests: when set and not

yea.. so when not set, it should be equal to

""

and not

"/"

ahh, ok

you should also add a test where you actually call an API to create a session and see that the path of the access token is correctly set

like this await Session.createNewSession(mockRequest(), mockResponse(), "userId");

no..

🥲

for example, see this test: https://github.com/supertokens/supertokens-node/blob/master/test/sessionExpress.test.js#L700

Maybe I am slowpoke, but where should i check it Like SuperTokens.init({ supertokens: { connectionURI: "http://localhost:8080", }, appInfo: { apiDomain: "api.supertokens.io", appName: "SuperTokens", websiteDomain: "supertokens.io", }, recipeList: [Session.init({ getTokenTransferMethod: () => "cookie", antiCsrf: "VIA_TOKEN" })], }); const app = express(); app.use(middleware()); app.post("/create", async (req, res) => { await Session.createNewSession(req, res, "", {}, {}); res.status(200).send(""); }); app.get(accesstokenpath_here, async (req, res) => { ...... })

after calling the create API

aaaaa

See this function: https://github.com/supertokens/supertokens-node/blob/811220bfd6679c40e3664687e5c086b18b1fa073/test/utils.js#L81 Instead of calling that function in your test, manually get the

sAccessToken

and see the path from that string

A

no worries 🙂

pushed tests

hey @IaS1506 i have released the new SDK version with your PR. It's version 13.5.0

🥰 👍

thank you for the work 🙂