https://github.com/Taz03/supertokens-core/actions/...
# contributingt
taz_03
10/06/2023, 11:01 AMhttps://github.com/Taz03/supertokens-core/actions/runs/6430750790/job/17462310987 im trying to contribute but the tests keep failing
r
rp_st
10/06/2023, 2:16 PMhey @taz_03 what were the configs you gave for the action when running it?
t
taz_03
10/07/2023, 5:33 AMr
rp_st
10/07/2023, 5:36 AMthat's odd. It doesn't have all the right params
rp_st
10/07/2023, 5:37 AMthese are all the params i see when running it from our repo
t
taz_03
10/07/2023, 1:25 PMmaybe because i don't have that repo forked?
taz_03
10/07/2023, 1:25 PMi'll try doing that
taz_03
10/07/2023, 1:30 PMstill no luck :c
taz_03
10/07/2023, 1:30 PMi'll just open a pr
r
rp_st
10/07/2023, 2:19 PMSounds good. We can run the tests for you if the PR looks good
t
taz_03
10/10/2023, 7:55 AM@rp_st do i also have to update changelog and update version in
build.gradler
rp_st
10/10/2023, 7:57 AMsure! please do
t
taz_03
10/10/2023, 11:23 AMdone
taz_03
10/10/2023, 12:55 PM@rp_st hey, i ran the tests locally and this was the results
taz_03
10/10/2023, 12:56 PM Copy code
---------------------------------------------------------------------------
| Results: FAILURE (1368 tests, 1295 successes, 73 failures, 0 skipped) |
---------------------------------------------------------------------------taz_03
10/10/2023, 12:56 PMthere are a few failed as well but those aren't tests of
InputParsertaz_03
10/10/2023, 12:56 PMso does that mean im good?
r
rp_st
10/10/2023, 12:57 PMNot sure. Will have to check. I’ll check once I have time this week
t
taz_03
10/10/2023, 12:57 PMbtw is this a job repo or just a hobby opensource project?
r
rp_st
10/10/2023, 1:01 PMjob repo
t
taz_03
10/12/2023, 6:09 AM@rp_st does docs changes also require mentioning in changelog? and build.gradle?
r
rp_st
10/12/2023, 6:11 AMdocs change? Normally, just the code changes are required to be mentioned.
t
taz_03
10/12/2023, 6:23 PMr
rp_st
10/12/2023, 6:27 PMah right. Docs change don't need to be mentioned in the changelog
t
taz_03
10/12/2023, 6:37 PMhttps://github.com/supertokens/supertokens-core/pull/830/files should i keep updating date of my pr changelog, or the old date is fine?
r
rp_st
10/12/2023, 6:38 PMno need to update the date. We will do it for you 🙂
t
taz_03
10/12/2023, 6:38 PMold date was actually 10, but i updated it once, i'll revert it if thats the case
taz_03
10/12/2023, 6:39 PMalso u'll merge the prs in october right? coz the repo is tagged "hacktoberfest"
r
rp_st
10/13/2023, 4:30 AMYup. On this weekend.
t
taz_03
10/15/2023, 1:41 PM@rp_st did u review my prs?
r
rp_st
10/15/2023, 2:12 PMyea, i just merged it into another working branch. We will have to make a few more changes, and will do so if and when we have time. We will try and release this along with the next big feature release.
Thanks!
t
taz_03
10/15/2023, 5:25 PMhttps://github.com/supertokens/supertokens-core/pull/840 what about this one