Channels
#general
Title
# general
a
alisha
05/17/2022, 9:46 AMHey all, I am trying to override an API response of CreateCodePOST - I want to override response of both success and error scenarios, is there any reference doc for the same? thanks
r
rp
05/17/2022, 9:48 AMhey @alisha
are you using golang on the backend?
a
alisha
05/17/2022, 9:48 AMyes
r
rp
05/17/2022, 9:51 AMok. give me a min
Copy code
go
func main() {
passwordless.Init(plessmodels.TypeInput{
Override: &plessmodels.OverrideStruct{
APIs: func(originalImplementation plessmodels.APIInterface) plessmodels.APIInterface {
originalCreateCodePOST := *originalImplementation.CreateCodePOST
(*originalImplementation.CreateCodePOST) = func(email, phoneNumber *string, options plessmodels.APIOptions, userContext supertokens.UserContext) (plessmodels.CreateCodePOSTResponse, error) {
resp, err := originalCreateCodePOST(email, phoneNumber, options, userContext)
if err != nil {
// this is usually some 500 error like core connection issues..
return plessmodels.CreateCodePOSTResponse{}, err
}
if resp.GeneralError != nil {
// this is usually some custom error message which will be displayed
// on the frontend
return resp, err
}
// code creation was successful
return resp, err
}
return originalImplementation
},
},
})
}so in the different
ifoptions.Resa
alisha
05/17/2022, 9:55 AMsuper, thanks will try this out
I am using thridpartypasswordless recipe, the init function takes the 1st param config of type tplmodels.TypeInput
the above example is of type plessmodels.TypeInput
r
rp
05/17/2022, 10:05 AMright yea.. so you will need to do according to that. But overall it's very similar
a
alisha
05/17/2022, 10:25 AMI have this case where I want to capture invalid phone error and modify the error message and http status code
Copy code
{
"message": "Phone number is invalid",
"status": "GENERAL_ERROR"
}I am not able to capture this message and status in the resp var
r
rp
05/17/2022, 10:28 AMAh right! Then you should provide the
ValidatePhoneNumberand validate the phone number and in case its invalid, you can return your own message
for validation of the phone number, you can copy the code from the SDK
a
alisha
05/17/2022, 10:29 AMoh okay
a
alisha
05/17/2022, 10:30 AMand I also want to handle bad request scenarios {
"message": "Please provide exactly one of email or phoneNumber"
}
in this case I want to change the message too
r
rp
05/17/2022, 10:33 AMWell.. to do that, you can add your own middleware which runs before our middleware, checks for the input if the path and method is = to the create code API and in case the input is bad, then you can send your own response
unfortunately, that's the easiest way to do this.
may i ask the use case for this?
a
alisha
05/17/2022, 10:35 AMgot it, thanks
r
rp
05/17/2022, 10:35 AMcause this message is returned only in case there is a coding error from the frontend - the end user should never see this anyway
a
alisha
05/17/2022, 10:35 AMjust exploring ways on how to go about using this
yes this will not go to the user anyway
r
rp
05/17/2022, 10:36 AMah right.. normally overriding a bad request error is not needed. But well,., it's possible regardles.
a
alisha
05/17/2022, 10:36 AMthanks a lot, this helped 🙂
hi again
r
rp
05/18/2022, 11:14 AMhey!
a
alisha
05/18/2022, 11:16 AMI tried implementing a custom phone validate function which returns a different error message, but is there a way to return a 400 response when there is a bad phone, instead of 200?
r
rp
05/18/2022, 11:19 AMhmm. For that, you will have to probably disable the default API and make your own using our functions from the SDK
a
alisha
05/18/2022, 11:19 AMoh ok, is there any reference for the same?
Actually, there is an easier way. In the custom validate function, you just return nil all the time (thereby saying that any phone number is valid).
That phone number will be then sent to the API call in which you can override it to check the format yourself. In case it's invalid, then you can send a custom response with whatever status code you want: https://supertokens.com/docs/thirdpartyemailpassword/advanced-customizations/apis-override/custom-response/api-override
a
alisha
05/18/2022, 11:26 AMoh will try that, thanks
hi again
I have implemented the above solution, but I am getting the following error
Headers were already written. Wanted to override status code 400 with 500
Copy code
(*originalImplementation.CreateCodePOST) = func(email *string, phoneNumber *string, optionsCreateCode plessmodels.APIOptions, userContextCreateCode supertokens.UserContext) (plessmodels.CreateCodePOSTResponse, error) {
err := validatePhone(*phoneNumber)
if err != nil {
responseJson := map[string]interface{}{
"message": err,
}
bytes, _ := json.Marshal(responseJson)
optionsCreateCode.Res.Header().Set("Content-Type", "application/json")
optionsCreateCode.Res.WriteHeader(400)
optionsCreateCode.Res.Write(bytes)
return plessmodels.CreateCodePOSTResponse{}, nil
}
return originalCreateCodePOST(email, phoneNumber, optionsCreateCode, userContextCreateCode)
}not sure what I am doing wrong
r
rp
05/19/2022, 10:44 AMCan you update to the latest version and try again? There was a bug related to this which we solved yesterday.
a
alisha
05/19/2022, 10:56 AMupgraded to v0.6.2, still facing the same error
r
rp
05/19/2022, 11:59 AMok checking. @sattvikc can help with this
s
sattvikc
05/19/2022, 12:04 PM@alisha I am verifying this, will get back
from quick look, seems like you are modifying the original implementation and entering recursion. instead can you try this code:
Copy code
originalCreateCodePOST = *originalImplementation.CreateCodePOST
newCreateCodePOST = func(email *string, phoneNumber *string, optionsCreateCode plessmodels.APIOptions, userContextCreateCode supertokens.UserContext) (plessmodels.CreateCodePOSTResponse, error) {
err := validatePhone(*phoneNumber)
if err != nil {
responseJson := map[string]interface{}{
"message": err,
}
bytes, _ := json.Marshal(responseJson)
optionsCreateCode.Res.Header().Set("Content-Type", "application/json")
optionsCreateCode.Res.WriteHeader(400)
optionsCreateCode.Res.Write(bytes)
return plessmodels.CreateCodePOSTResponse{}, nil
}
return originalCreateCodePOST(email, phoneNumber, optionsCreateCode, userContextCreateCode)
}
originalImplementation.CreateCodePOST = &newCreateCodePOSTr
rp
05/19/2022, 12:14 PM@sattvikc it's not a problem of infinite recursion
Cause
originalCreateCodePOSTs
sattvikc
05/19/2022, 12:15 PMI'll implement locally and suggest the fix
r
rp
05/19/2022, 12:15 PMsince a custom response is being sent
So it's some other issue
a
alisha
05/19/2022, 12:32 PMthanks @sattvikc
s
sattvikc
05/19/2022, 12:53 PM@alisha please try this:
Copy code
(*originalImplementation.CreateCodePOST) = func(email *string, phoneNumber *string, optionsCreateCode plessmodels.APIOptions, userContextCreateCode supertokens.UserContext) (plessmodels.CreateCodePOSTResponse, error) {
err := validatePhone(*phoneNumber)
if err != nil {
responseJson := map[string]interface{}{
"message": err.Error(),
}
bytes, _ := json.Marshal(responseJson)
optionsCreateCode.Res.Header().Set("Content-Type", "application/json")
optionsCreateCode.Res.WriteHeader(400)
optionsCreateCode.Res.Write(bytes)
return plessmodels.CreateCodePOSTResponse{
OK: &struct {
DeviceID string
PreAuthSessionID string
FlowType string
}{},
}, nil
}
return originalCreateCodePOST(email, phoneNumber, optionsCreateCode, userContextCreateCode)
}
return originalImplementationa
alisha
05/19/2022, 2:48 PMnot sure what is going wrong, but it looks like I am not able to override the CreateCodePOST function
r
rp
05/19/2022, 2:49 PMCan you share more of the code?
The whole Override input object perhaps
a
alisha
05/19/2022, 2:50 PMsupertokens.Init
r
rp
05/19/2022, 2:52 PMSo it seems about right. But the
fmt.Println("inside override")err := validatePhone(*phoneNumber)can you move the log right above
err := validatePhone(*phoneNumber)a
alisha
05/19/2022, 2:53 PMits not logging trued before err := validatePhone(*phoneNumber)
r
rp
05/19/2022, 2:53 PMwhat is the output?
a
alisha
05/19/2022, 2:54 PMits printing if its not a bad number
if I pass an invalid number I dont see the log printing
r
rp
05/19/2022, 2:54 PMwhat do you see in that case? what is the API's output?
a
alisha
05/19/2022, 2:55 PM Copy code
{
"message": "Phone number is invalid",
"status": "GENERAL_ERROR"
}with a 200
r
rp
05/19/2022, 2:55 PMah right yea.. cause it's using our default validator which is rejecting the request before your override function is called
a
alisha
05/19/2022, 2:56 PMoh yes, I missed thus
r
rp
05/19/2022, 2:56 PMWhat have you given in
ContactMethodPhonea
alisha
05/19/2022, 2:56 PMtrying with a custom validator
r
rp
05/19/2022, 2:57 PMyou should give something like:
Copy code
go
ContactMethodPhone: plessmodels.ContactMethodPhoneConfig{
ValidatePhoneNumber: func(phoneNumber interface{}) *string {
return nil
},
},this will basically allow any phone number to pass through
and should call your override function
a
alisha
05/19/2022, 2:58 PMworking now, I missed adding a custom validate phone number function which returns nil
r
rp
05/19/2022, 2:59 PMcool!
a
alisha
05/19/2022, 2:59 PMthanks a lot!
hey again
this time I am overriding ThirdPartySignInUpPOST to return a custom response
I am getting the following
Copy code
Headers were already written. Wanted to override status code 200 with 500r
rp
05/25/2022, 8:05 AM@sattvikc can you see this please?
s
sattvikc
05/25/2022, 8:08 AM@rp sure
@alisha could you share your code snippet?
r
rp
05/25/2022, 8:10 AMIt’s shared already
See the message.txt file
s
sattvikc
05/25/2022, 8:13 AMI'll verify and get back
hi @alisha
a
alisha
05/25/2022, 10:25 AMhey
s
sattvikc
05/25/2022, 10:25 AMcan you update ur return statement to this:
a
alisha
05/25/2022, 10:27 AMworked
thanks a ton!
s
sattvikc
05/25/2022, 10:30 AMpleasure 🙂
generally on any override, ensure no nil is passed with the OK response
a
alisha
05/25/2022, 11:28 AMwill take care, thanks
r
rp
05/26/2022, 10:05 AMhey @alisha thanks for pointing this error out. You can use our latest version (0.6.4) which contains this bug fix.
a
alisha
05/26/2022, 10:18 AMok, thanks @rp
2 Views