https://supertokens.com/docs/thirdpartyemailpasswo...
# support-questions-legacyp
productdevbook
12/14/2022, 6:55 AMhttps://supertokens.com/docs/thirdpartyemailpassword/common-customizations/deduplication/implementing-deduplication
Copy code
ts
thirdPartySignInUpPOST: async (input) => {
try {
await originalImplementation.thirdPartySignInUpPOST!(input)
}
catch (err: any) {
if (err.message === 'Cannot sign up as email already exists') {
// this error was thrown from our function override above.
// so we send a useful message to the user
return {
status: 'GENERAL_ERROR',
message: 'Seems like you already have an account with another method. Please use that instead.',
}
}
throw err
}r
rp_st
12/14/2022, 6:56 AMhey @productdevbook it seems to be an issue with how you may have configured the github provider.
rp_st
12/14/2022, 6:56 AM@sattvikc can help here
s
sattvikc
12/14/2022, 6:58 AMjust a min, taking a look
sattvikc
12/14/2022, 7:00 AMcan i see your github init ?
p
productdevbook
12/14/2022, 7:00 AM Copy code
ts
recipeList: [
ThirdPartyEmailPassword.init({
providers: [
Github({
clientId: env.github.appId,
clientSecret: env.github.privateKey,
}),
],productdevbook
12/14/2022, 7:02 AMbut login client and supertoken token etc coming
s
sattvikc
12/14/2022, 7:03 AMis the privateKey same as clientSecret provided by github ?
p
productdevbook
12/14/2022, 7:04 AMyes
productdevbook
12/14/2022, 7:04 AMbut dont used
productdevbook
12/14/2022, 7:05 AMHow can I login even though it gives an error?
s
sattvikc
12/14/2022, 7:05 AMcan you check if the env is set correctly ?
p
productdevbook
12/14/2022, 7:06 AMyes same code
s
sattvikc
12/14/2022, 7:06 AMit worked earlier?
p
productdevbook
12/14/2022, 7:07 AMIt still works, I'm officially logging in, but that error always comes
s
sattvikc
12/14/2022, 7:09 AMthe 401 error typically means the token was not acquired on the token API. could you replicate that request on the postman ?
p
productdevbook
12/14/2022, 7:09 AMAgainst the error, your system registers the user and the token is returned. interested
s
sattvikc
12/14/2022, 7:10 AMstrange! just to be sure, which error are you referring to ?
sattvikc
12/14/2022, 7:11 AMif the user API does not pass, the user will not be added to the core
p
productdevbook
12/14/2022, 7:12 AMno your system added
productdevbook
12/14/2022, 7:12 AMall delete db and reset github user
productdevbook
12/14/2022, 7:12 AMand after login same
productdevbook
12/14/2022, 7:13 AMand return token your system and login client
productdevbook
12/14/2022, 7:14 AMsuper token db
productdevbook
12/14/2022, 7:14 AMthis error backend code.
s
sattvikc
12/14/2022, 7:15 AMdo u mean the backend has an issue with the API call and still the login works as expected?
p
productdevbook
12/14/2022, 7:15 AMyes
s
sattvikc
12/14/2022, 7:15 AMis the returned email correct as well?
p
productdevbook
12/14/2022, 7:15 AMyes
s
sattvikc
12/14/2022, 7:16 AMcould you share your complete supertokens init? maybe I can try to reproduce and see
p
productdevbook
12/14/2022, 7:16 AMmy backend code
s
sattvikc
12/14/2022, 7:16 AMlet me know your frontend and backend SDK versions as well
p
productdevbook
12/14/2022, 7:17 AM"supertokens-web-js": "^0.3.0",
"supertokens-node": "^12.1.2",
s
sattvikc
12/14/2022, 7:17 AMokay, let me get back to u in a while
p
productdevbook
12/14/2022, 7:17 AMawait originalImplementation.thirdPartySignInUpPOST!(input)s
sattvikc
12/14/2022, 7:20 AMnot sure I understand that correctly, what did you delete?
p
productdevbook
12/14/2022, 7:22 AMI get an error when I add the code
r
rp_st
12/14/2022, 7:22 AMYou can't delete
await originalImplementation.thirdPartySignInUpPOST!(input)rp_st
12/14/2022, 7:22 AMok so the problem is that you are calling
await originalImplementation.thirdPartySignInUpPOST!(input)rp_st
12/14/2022, 7:22 AMthat will, obviously, not work
p
productdevbook
12/14/2022, 7:23 AMAccording to your docs I have added those codes but it is causing the error
r
rp_st
12/14/2022, 7:23 AMIf you see in our docs, we call
await originalImplementation.thirdPartySignInUpPOSTrp_st
12/14/2022, 7:23 AMbut you are calling it twice.
rp_st
12/14/2022, 7:23 AMSo the second time is failing.
rp_st
12/14/2022, 7:23 AMwhich is expected
rp_st
12/14/2022, 7:23 AMThis is the code in the file you sent above:
Copy code
thirdPartySignInUpPOST: async (input) => {
try {
await originalImplementation.thirdPartySignInUpPOST!(input)
if (!originalImplementation.thirdPartySignInUpPOST)
throw new Error('thirdPartySignInUpPOST is not available')
const response = await originalImplementation.thirdPartySignInUpPOST(input)
if (response.status === 'OK') {
const externalUserId = response.user.thirdParty
? `${response.user.thirdParty.id}|${response.user.thirdParty.userId}`
: null
await storage.userRepo.ensureUserExists({
superTokensUserId: response.user.id,
email: response.user.email,
externalAuthUserId: externalUserId || undefined,
})
}
return response
}rp_st
12/14/2022, 7:24 AMAnd as you can see, you are calling
await originalImplementation.thirdPartySignInUpPOST!(input)const response = await originalImplementation.thirdPartySignInUpPOST(input)rp_st
12/14/2022, 7:24 AMSo your override code is just wrong.
p
productdevbook
12/14/2022, 7:24 AM Copy code
ts
try {
const response = await originalImplementation.thirdPartySignInUpPOST!(input)
if (!originalImplementation.thirdPartySignInUpPOST)
throw new Error('thirdPartySignInUpPOST is not available')
if (response.status === 'OK') {
const externalUserId = response.user.thirdParty
? `${response.user.thirdParty.id}|${response.user.thirdParty.userId}`
: null
await storage.userRepo.ensureUserExists({
superTokensUserId: response.user.id,
email: response.user.email,
externalAuthUserId: externalUserId || undefined,
})
}
return response
}productdevbook
12/14/2022, 7:24 AMthats true ?
r
rp_st
12/14/2022, 7:24 AMwhats before the
tryp
productdevbook
12/14/2022, 7:25 AM Copy code
ts
thirdPartySignInUpPOST: async (input) => {
try {
const response = await originalImplementation.thirdPartySignInUpPOST!(input)
if (!originalImplementation.thirdPartySignInUpPOST)
throw new Error('thirdPartySignInUpPOST is not available')
if (response.status === 'OK') {
const externalUserId = response.user.thirdParty
? `${response.user.thirdParty.id}|${response.user.thirdParty.userId}`
: null
await storage.userRepo.ensureUserExists({
superTokensUserId: response.user.id,
email: response.user.email,
externalAuthUserId: externalUserId || undefined,
})
}
return response
}
catch (err: any) {
if (err.message === 'Cannot sign up as email already exists') {
// this error was thrown from our function override above.
// so we send a useful message to the user
return {
status: 'GENERAL_ERROR',
message: 'Seems like you already have an account with another method. Please use that instead.',
}
}
throw err
}
},r
rp_st
12/14/2022, 7:25 AMyea. this seems fine
rp_st
12/14/2022, 7:26 AMif this also doens't work, then please check your github credentials,.
p
productdevbook
12/14/2022, 7:26 AMokay thank you now fixed
productdevbook
12/14/2022, 7:26 AMand email signup return error 🔥
r
rp_st
12/14/2022, 7:26 AMnice
p
productdevbook
12/14/2022, 7:27 AMI am working on a project of mine. I will sponsor you once I go live and start making money.
productdevbook
12/14/2022, 7:27 AMThanks for all the help
4 Views