Hey <@498057949541826571> Following up on the Resp...
# support-questions-legacya
anujchhabria
12/28/2022, 7:00 AMHey @rp_st Following up on the Response issue
r
rp_st
12/28/2022, 7:01 AMhey @anujchhabria
rp_st
12/28/2022, 7:01 AMlet's talk in this thread
rp_st
12/28/2022, 7:01 AMplease summarise the problem
a
anujchhabria
12/28/2022, 7:01 AMSure
r
rp_st
12/28/2022, 7:01 AM@kakashi_44 can help here
a
anujchhabria
12/28/2022, 7:01 AMThe exception occurred while attempting to log: Argument 1 passed to SuperTokens\Helpers\CookieAndHeader::attachAccessTokenToCookie() must be an instance of Illuminate\Http\Response, instance of Illuminate\Http\JsonResponse given, called in /var/www/classcard/vendor/supertokens/supertokens-laravel/src/Http/Middleware.php on line 69
This is the error
anujchhabria
12/28/2022, 7:01 AMMostly seems to be happening on the refresh
anujchhabria
12/28/2022, 7:02 AMWe also do get this on our user api often
anujchhabria
12/28/2022, 7:02 AMThe exception occurred while attempting to log: access token missing in cookies
k
kakashi_44
12/28/2022, 7:04 AMHey @anujchhabria , is the login API working correctly? The one where createNewSession is used. Are the cookies getting set correctly in response for that API?
a
anujchhabria
12/28/2022, 7:04 AMYep, all working fine on login
anujchhabria
12/28/2022, 7:04 AMcookie is set on the browser without any issue
anujchhabria
12/28/2022, 7:05 AMSo to summarize, we have 2 issues:
1. On the user api - after the session has been active for sometime - we get the access token missing in cookies
2. refresh api - Argument 1 passed to SuperTokens\Helpers\CookieAndHeader::attachAccessTokenToCookie() must be an instance of Illuminate\Http\Response, instance of Illuminate\Http\JsonResponse given, called in /var/www/classcard/vendor/supertokens/supertokens-laravel/src/Http/Middleware.php on line 69
k
kakashi_44
12/28/2022, 7:06 AMgot it
kakashi_44
12/28/2022, 7:06 AMIs there an part in the code, where a supertokens function is being called and a JSONResponse object is passed?
a
anujchhabria
12/28/2022, 7:13 AMjust double checked
anujchhabria
12/28/2022, 7:13 AMdoes not seem like it
k
kakashi_44
12/28/2022, 7:19 AMokay
kakashi_44
12/28/2022, 7:22 AMHow is the refresh route implemented. Can you share code snippet of that part?
a
anujchhabria
12/28/2022, 7:24 AMpublic function refresh (Request $request) {
return "";
}
anujchhabria
12/28/2022, 7:24 AManujchhabria
12/28/2022, 7:24 AMas per the docs this is what it has to be
k
kakashi_44
12/28/2022, 7:32 AMgot it, thanks
kakashi_44
12/28/2022, 7:32 AMare you using JSONResponse in any of your API?
a
anujchhabria
12/28/2022, 7:39 AMyes
anujchhabria
12/28/2022, 7:39 AMin one of the apis we had to, to manage some character encoding
k
kakashi_44
12/28/2022, 9:26 AMthe issue can be, after the refresh API is called, it returns with new refresh token and access token. The API that is called right after the refresh API, the new access token is verified and the older refresh token is discarded. This updates the payload of access token. Now because that API might be returning JSONResponse, the issue gets triggered. It makes sense now why it could be happening after the refresh API call
a
anujchhabria
12/28/2022, 9:43 AMI see, how do we work around this?
anujchhabria
12/28/2022, 9:43 AMalso - what about this one - 1. On the user api - after the session has been active for sometime - we get the access token missing in cookies
r
rp_st
12/28/2022, 10:25 AM@anujchhabria you have two options:
- Never use JsonResponse in any API; OR
- Fork our laravel repo and remove Response type from places like this: https://github.com/supertokens/supertokens-laravel/blob/master/src/Helpers/CookieAndHeader.php#L106